Gashaponsition#2044
Open
MothHours wants to merge 5 commits into
Open
Conversation
Updated Prizeball laying systems to match the equivalent LewdEggLaying System, and made the trait appear in the traits tab
AutumnalModding
suggested changes
Jun 11, 2026
AutumnalModding
left a comment
AutumnalModding
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good I think. Got a few comments, mostly nitpicks though.
| @@ -1,4 +1,5 @@ | |||
| flavor-woof = like woof | |||
| flavor-highscore = Like a sweet sweet highscore. | |||
Collaborator
There was a problem hiding this comment.
Should be lowercase.
| using Robust.Shared.Prototypes; | ||
| using Content.Shared.Animals.Systems; | ||
|
|
||
| namespace Content.Shared.Animals.Components; // HL: Moved this to Shared so the client can use it for verb drawing. |
Collaborator
There was a problem hiding this comment.
No need for HL comments in HL namespace
|
|
||
| namespace Content.Client.Animals.Systems; | ||
|
|
||
| // HL: This is just an empty class so that the matching code in SharedPrizeballLayingSystem can run on the client. |
Collaborator
There was a problem hiding this comment.
No need for HL comments in HL namespace
| @@ -0,0 +1,26 @@ | |||
| using Content.Shared.EntityEffects; | |||
| using Content.Shared.Animals.Components; // HL: Moved the LewdEggLayingComponent to Shared | |||
Collaborator
There was a problem hiding this comment.
No need for HL comments in HL namespace
Comment on lines
+46
to
+60
| - type: Food | ||
| solution: food | ||
| delay: 0.25 | ||
| forceFeedDelay: 1 | ||
| - type: FlavorProfile | ||
| flavors: | ||
| - paper | ||
| - type: BadFood | ||
| - type: SolutionContainerManager | ||
| solutions: | ||
| food: | ||
| maxVol: 1 | ||
| reagents: | ||
| - ReagentId: PrizeballJuice | ||
| Quantity: .1 |
Collaborator
There was a problem hiding this comment.
Missing HL comments
Collaborator
There was a problem hiding this comment.
Should be in HL namespace
Collaborator
|
@MothHours why re-request a review without actually pushing changes...? |
Collaborator
|
Also your linter is failing: |
Contributor
Author
Sorry! I did not mean to do that, very new to Github. |
Removed the HL tag from comments on code in HL folder Fixed the flavor Fixed maxPballs being maxEggs in lewd.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Copied/reworked the Egglaying trait code to need a new reagent PrizeballJuice, Localized as: "Juice that makes you prizeball" that causes a player with the trait to form and be able to lay prizeballs.
Why / Balance
Just another fun flavor/kink trait, I do not think it should impact game balance as the number of tickets needed per prizeball is the same as the prize counter.
Technical details
Copies most of the LewdEggLaying code into equivalently named files for the trait.
How to test
Give your test character the trait
Consume prize tickets
Wait.
Lay Prizeball action should pop up, clicking it should lay a prizeball.
Add an entity with the "actor" server and client component.
"Lay Prizeball inside" should appear in that entities verb menu.
Media
Breaking changes
Changelog
🆑 add: Added Gashaponsition, a new trait that lets you lay prizeballs.